Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S2187: Test files should contain at least one test case #4442

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4428

export const rule: Rule.RuleModule = {
meta: {
messages: {
missingTest: 'Add some tests to this file.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
missingTest: 'Add some tests to this file.',
missingTest: 'Add some tests to this file or delete it.',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would require to adapt the invalid unit test case(s)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small questions and suggestions, otherwise LGTM!

Copy link

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 96387c2 into master Nov 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rule S2187: Test files should contain at least one test case
2 participants